fix emit for delete on optional chain - #35090
#35090Merged
Merged
fix emit for delete on optional chain#35090
Conversation
ajafff
force-pushed
the
optchain-delete
branch
from
November 14, 2019 21:20
aa365a4 to
7055cad
Compare
Contributor
|
Can you update this branch now that #34951 has been merged? |
ajafff
force-pushed
the
optchain-delete
branch
from
November 15, 2019 07:57
7055cad to
7df9a5c
Compare
Contributor
Author
|
rebased on master |
Member
|
@rbuckton LGTM, care to merge? |
rbuckton
approved these changes
Nov 15, 2019
Contributor
|
@RyanCavanaugh: Unfortunately I can't commit the suggestions myself as part of the PR. Should I merge this as is and address separately, or wait for @ajafff to update? |
Co-Authored-By: Ron Buckton <ron.buckton@microsoft.com>
rbuckton
approved these changes
Nov 19, 2019
|
Hi, Is it release ? Do you have any kind of roadmap for bugfix like this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #35084
@rbuckton for review