Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix type inference regression#34607

Merged
ahejlsberg merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
fix33490microsoft/TypeScript:fix33490Copy head branch name to clipboard
Oct 21, 2019
Merged

Fix type inference regression#34607
ahejlsberg merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
fix33490microsoft/TypeScript:fix33490Copy head branch name to clipboard

Conversation

@ahejlsberg

Copy link
Copy Markdown
Member

Fixes #33490.

@ahejlsberg ahejlsberg added this to the TypeScript 3.7.1 milestone Oct 21, 2019
@ahejlsberg

Copy link
Copy Markdown
Member Author

@typescript-bot test this
@typescript-bot run dt

@typescript-bot

typescript-bot commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 82019d6. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

typescript-bot commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 82019d6. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg

Copy link
Copy Markdown
Member Author

The RWC tests are clean and the DT test failures are pre-existing conditions. So, looks good.

@ahejlsberg ahejlsberg merged commit f84fd30 into master Oct 21, 2019
@ahejlsberg ahejlsberg deleted the fix33490 branch October 21, 2019 19:50
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression for inferred unions in generic parameters

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.