Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Assert ranges exist when looped over in fourslash#32012

Merged
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:add-fourslash-assertsweswigham/TypeScript:add-fourslash-assertsCopy head branch name to clipboard
Jun 21, 2019
Merged

Assert ranges exist when looped over in fourslash#32012
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:add-fourslash-assertsweswigham/TypeScript:add-fourslash-assertsCopy head branch name to clipboard

Conversation

@weswigham

@weswigham weswigham commented Jun 20, 2019

Copy link
Copy Markdown
Member

Fixes #6120

@DanielRosenwasser

DanielRosenwasser commented Jun 21, 2019

Copy link
Copy Markdown
Member

I think this is fine within the fourslash harness, but does this work with the tests which just use a for-loop to iterate over ranges?

@weswigham

weswigham commented Jun 21, 2019

Copy link
Copy Markdown
Member Author

but does this work with the tests which just use a for-loop to iterate over ranges?

You should be using verify.forEachRange if you do that AFAIK, so yes. If you grab the list of ranges otherwise, then no.

@weswigham weswigham merged commit fe2b9e9 into microsoft:master Jun 21, 2019
@weswigham weswigham deleted the add-fourslash-asserts branch June 21, 2019 17:38
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@weswigham weswigham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fourslash tests which loop over every range should assert the presence of a non-empty list of ranges

3 participants

@weswigham @DanielRosenwasser @sheetalkamat
Morty Proxy This is a proxified and sanitized view of the page, visit original site.