Use execFileSync in typing installer#29816
Merged
sheetalkamat merged 1 commit intoFeb 15, 2019
Merged
Conversation
weswigham
reviewed
Feb 8, 2019
| return `--user-agent="typesInstaller/${tsVersion}"`; | ||
| } | ||
| const npmInstall = "install", ignoreScripts = "--ignore-scripts", saveDev = "--save-dev"; | ||
| const commandBaseLength = npmInstall.length + ignoreScripts.length + saveDev.length + getUserAgent("").length + 5; |
Member
There was a problem hiding this comment.
Should just say getUserAgent("0.0.0") rather than adding the + 5, IMO.
Member
Author
There was a problem hiding this comment.
- 5 is for the spaces around them (the tsversion length is added later on while computing actual command length as we use to.
Member
There was a problem hiding this comment.
Ah. That was not immediately clear, sorry.
Member
Author
|
Ping @RyanCavanaugh |
RyanCavanaugh
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.