Fix implement interface quickfix import types#29410
Merged
weswigham merged 3 commits intoJan 14, 2019
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-implement-interface-quickfix-import-typesweswigham/TypeScript:fix-implement-interface-quickfix-import-typesCopy head branch name to clipboard
Merged
Fix implement interface quickfix import types#29410weswigham merged 3 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:fix-implement-interface-quickfix-import-typesweswigham/TypeScript:fix-implement-interface-quickfix-import-typesCopy head branch name to clipboard
weswigham merged 3 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-implement-interface-quickfix-import-typesweswigham/TypeScript:fix-implement-interface-quickfix-import-typesCopy head branch name to clipboard
Conversation
sheetalkamat
left a comment
Member
There was a problem hiding this comment.
The change looks good except the question about signature help (with dynamicImport.C as parameter invocation?)
Member
Author
|
@sheetalkamat the |
sheetalkamat
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
implmentsquick fixes were not providing the host required to generate good paths for import types into the type node helpers they used, so they were always generating absolute paths (or amd module names).Fixes #29406