Fix #29168#29174
Closed
jack-williams wants to merge 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
jack-williams:apparent-contextual-typejack-williams/TypeScript:apparent-contextual-typeCopy head branch name to clipboard
Closed
Fix #29168#29174jack-williams wants to merge 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom jack-williams:apparent-contextual-typejack-williams/TypeScript:apparent-contextual-typeCopy head branch name to clipboard
jack-williams wants to merge 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
jack-williams:apparent-contextual-typejack-williams/TypeScript:apparent-contextual-typeCopy head branch name to clipboard
Conversation
weswigham
approved these changes
Jan 2, 2019
weswigham
left a comment
Member
There was a problem hiding this comment.
Exactly the right change to make, IMO.
Collaborator
Author
|
Closing in favour of #29478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29168
I'm slightly worried this is the wrong approach, and/or is a breaking change. Candidate PR up anyways.