Fix control flow analysis of destructuring in loops#28784
Merged
ahejlsberg merged 3 commits intoDec 1, 2018
mastermicrosoft/TypeScript:masterfrom
controlFlowDestructuringLoopmicrosoft/TypeScript:controlFlowDestructuringLoopCopy head branch name to clipboard
Merged
Fix control flow analysis of destructuring in loops#28784ahejlsberg merged 3 commits intomastermicrosoft/TypeScript:masterfrom controlFlowDestructuringLoopmicrosoft/TypeScript:controlFlowDestructuringLoopCopy head branch name to clipboard
ahejlsberg merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
controlFlowDestructuringLoopmicrosoft/TypeScript:controlFlowDestructuringLoopCopy head branch name to clipboard
Conversation
Member
Author
|
Short explanation is that we now treat the following as equivalent for purposes of control flow analysis: const y = foo.x.y;
const { y } = foo.x;
const { x: { y } } = foo; |
DanielRosenwasser
approved these changes
Dec 1, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28758.