Ensure TypeChecker#getTypeAtLocation returns a defined result#25583
Merged
3 commits merged intoJul 11, 2018
Merged
Ensure TypeChecker#getTypeAtLocation returns a defined result#255833 commits merged into
3 commits merged into
Conversation
sandersn
approved these changes
Jul 11, 2018
sandersn
left a comment
Member
There was a problem hiding this comment.
I guess no baselines changed because all the other callers were already correct?
In theory it would be nice to get a test case based on the bug this fixes, although with just a stack trace you'd have to make it from scratch.
Author
|
This function was basically assumed to return a defined result everywhere. It's only had the |
mhegazy
approved these changes
Jul 11, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25577