Don't consider x. a new identifier location just because x has a number index signature#24699
Merged
2 commits merged intoJun 7, 2018
mastermicrosoft/TypeScript:masterfrom
dotIsNewIdentifierLocationmicrosoft/TypeScript:dotIsNewIdentifierLocationCopy head branch name to clipboard
Merged
Don't consider x. a new identifier location just because x has a number index signature#246992 commits merged intomastermicrosoft/TypeScript:masterfrom dotIsNewIdentifierLocationmicrosoft/TypeScript:dotIsNewIdentifierLocationCopy head branch name to clipboard
x. a new identifier location just because x has a number index signature#246992 commits merged into
mastermicrosoft/TypeScript:masterfrom
dotIsNewIdentifierLocationmicrosoft/TypeScript:dotIsNewIdentifierLocationCopy head branch name to clipboard
Conversation
…mber index signature
mhegazy
approved these changes
Jun 6, 2018
RyanCavanaugh
approved these changes
Jun 6, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24690
We considered
"a".to be a new identifier location because"a"has a number index signature. But typing a number after the.wouldn't parse, so it makes sense to consider the completions we return complete.