moveToNewFile: Don't provide refactor if selection is just imports#24336
Merged
1 commit merged intoMay 22, 2018
mastermicrosoft/TypeScript:masterfrom
moveToNewFile_selectionOnImportsmicrosoft/TypeScript:moveToNewFile_selectionOnImportsCopy head branch name to clipboard
Merged
moveToNewFile: Don't provide refactor if selection is just imports#243361 commit merged intomastermicrosoft/TypeScript:masterfrom moveToNewFile_selectionOnImportsmicrosoft/TypeScript:moveToNewFile_selectionOnImportsCopy head branch name to clipboard
1 commit merged into
mastermicrosoft/TypeScript:masterfrom
moveToNewFile_selectionOnImportsmicrosoft/TypeScript:moveToNewFile_selectionOnImportsCopy head branch name to clipboard
Conversation
mhegazy
approved these changes
May 22, 2018
Contributor
|
we need to port this to release-2.9 as well. |
ghost
pushed a commit
that referenced
this pull request
May 22, 2018
ghost
pushed a commit
that referenced
this pull request
May 22, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #24177 we don't move imports; this means that we should check the result of
getStatementsToMoveinstead of justgetFirstAndLastStatementToMove.