Don't collect open-file telemetry on the syntax server#24178
Merged
amcasey merged 1 commit intoMay 16, 2018
microsoft:mastermicrosoft/TypeScript:masterfrom
amcasey:SyntaxServerOpenFileTelemetryamcasey/TypeScript:SyntaxServerOpenFileTelemetryCopy head branch name to clipboard
Merged
Don't collect open-file telemetry on the syntax server#24178amcasey merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom amcasey:SyntaxServerOpenFileTelemetryamcasey/TypeScript:SyntaxServerOpenFileTelemetryCopy head branch name to clipboard
amcasey merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
amcasey:SyntaxServerOpenFileTelemetryamcasey/TypeScript:SyntaxServerOpenFileTelemetryCopy head branch name to clipboard
Conversation
It's throwing an exception (since there's no program from which to retrieve the SourceFile) and there's no reason to fix it since the same files are open in the semantic server.
Member
Author
|
Without this change, the syntax server is broken and a bunch of operations don't work in VS. |
mhegazy
approved these changes
May 16, 2018
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's throwing an exception (since there's no program from which to retrieve the SourceFile) and there's no reason to fix it since the same files are open in the semantic server.