Fix conversion of TextChanges to FileCodeEdits for new file#24126
Merged
1 commit merged intoMay 15, 2018
Merged
Fix conversion of TextChanges to FileCodeEdits for new file#241261 commit merged into
1 commit merged into
Conversation
mhegazy
approved these changes
May 15, 2018
Contributor
|
We should add a fourslash/server test for this. but i would do that in a different PR, since the infrastructure is not there yet. |
mjbvz
approved these changes
May 15, 2018
mjbvz
left a comment
Contributor
There was a problem hiding this comment.
Seems to work now. Thanks!
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #24118
@mjbvz Could you test this out in your branch?