Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level.#24101
Merged
1 commit merged intoMay 14, 2018
mastermicrosoft/TypeScript:masterfrom
convertToEs6Module_notAtTopLevelmicrosoft/TypeScript:convertToEs6Module_notAtTopLevelCopy head branch name to clipboard
Merged
Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level.#241011 commit merged intomastermicrosoft/TypeScript:masterfrom convertToEs6Module_notAtTopLevelmicrosoft/TypeScript:convertToEs6Module_notAtTopLevelCopy head branch name to clipboard
1 commit merged into
mastermicrosoft/TypeScript:masterfrom
convertToEs6Module_notAtTopLevelmicrosoft/TypeScript:convertToEs6Module_notAtTopLevelCopy head branch name to clipboard
Conversation
…ort/export appears at top-level.
4b1e90b to
a42afdf
Compare
mhegazy
approved these changes
May 14, 2018
sandersn
pushed a commit
that referenced
this pull request
May 16, 2018
…ort/export appears at top-level. (#24101)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code fix doesn't work for non-top-level imports/exports, so better to not add a suggestion diagnostic in that case.