Add declarationDir to excludeSpec#24056
Merged
mhegazy merged 2 commits intoMay 11, 2018
microsoft:mastermicrosoft/TypeScript:masterfrom
a-tarasyuk:bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecsa-tarasyuk/TypeScript:bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecsCopy head branch name to clipboard
Merged
Add declarationDir to excludeSpec#24056mhegazy merged 2 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom a-tarasyuk:bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecsa-tarasyuk/TypeScript:bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecsCopy head branch name to clipboard
mhegazy merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
a-tarasyuk:bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecsa-tarasyuk/TypeScript:bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecsCopy head branch name to clipboard
Conversation
Contributor
|
thanks @a-tarasyuk, can you also add a test for it. tests are in https://github.com/Microsoft/TypeScript/blob/master/src/harness/unittests/tsconfigParsing.ts |
mhegazy
reviewed
May 11, 2018
| else if (raw.compilerOptions) { | ||
| const outDir = raw.compilerOptions.outDir; | ||
| const declarationDir = raw.compilerOptions.declarationDir; | ||
| const excludeDirs = [outDir, declarationDir].filter(dir => dir); |
Contributor
There was a problem hiding this comment.
nit. i would write this as:
if (outDir || declarationDir) {
excludeSpecs = [outDir, declarationDir].filter(d => !!d);
}
Contributor
Author
|
@mhegazy ok |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23891