Prevent infinite js symbol merge in the checker#24011
Closed
sandersn wants to merge 1 commit into
release-2.8microsoft/TypeScript:release-2.8from
prevent-infinite-js-symbol-mergemicrosoft/TypeScript:prevent-infinite-js-symbol-mergeCopy head branch name to clipboard
Closed
Prevent infinite js symbol merge in the checker#24011sandersn wants to merge 1 commit intorelease-2.8microsoft/TypeScript:release-2.8from prevent-infinite-js-symbol-mergemicrosoft/TypeScript:prevent-infinite-js-symbol-mergeCopy head branch name to clipboard
sandersn wants to merge 1 commit into
release-2.8microsoft/TypeScript:release-2.8from
prevent-infinite-js-symbol-mergemicrosoft/TypeScript:prevent-infinite-js-symbol-mergeCopy head branch name to clipboard
Conversation
This just cuts off the infinite merging; it doesn't address the underlying bug which is probably in bindPropertyAssignment.
Member
Author
|
This PR is obsoleted by the better #24050 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just cuts off the infinite merging; it doesn't address the underlying bug which is probably in bindPropertyAssignment.
Note that we're still waiting on a repro. Currently it looks like there is more than one library that fails.