Add refreshDiagnostics() method to Project#23824
Merged
2 commits merged intoMay 7, 2018
Merged
Add refreshDiagnostics() method to Project#238242 commits merged into
2 commits merged into
Conversation
sheetalkamat
requested changes
May 2, 2018
sheetalkamat
left a comment
Member
There was a problem hiding this comment.
I do not think we should be exposing ProjectService here. The change in tsconfig file is project scoped not whole service dependent. The sendProjectsUpdatedInBackgroundEvent is event to session to inform about the changes in various projects and it shouldnt be used for this purpose.
Author
|
Maybe we could add a method on |
387b854 to
4614719
Compare
sheetalkamat
approved these changes
May 7, 2018
Author
|
Awaiting @mhegazy to approve just to be sure |
mhegazy
approved these changes
May 7, 2018
Member
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15914 and #15915
Using this, a plugin should be able to call
sendProjectsUpdatedInBackgroundEventon theProjectServicewhen it notices a config file has changed. Then we should request diagnostics again.(Note: this includes having the plugin watch
tsconfig.jsonif it needs to, instead of having the server notify the plugin for that.)CC @egamma