Unclosurefy patternMatcher#23071
Merged
2 commits merged intoApr 2, 2018
Merged
Conversation
37e82f6 to
e314ea0
Compare
mhegazy
approved these changes
Apr 2, 2018
933c901 to
1959bff
Compare
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View diff with
?w=1since everything went down a level of indentation.For the most part this just moves functions out of
createPatternMatcher; most of those closed over nothing so this is easy. (Though it's nice to be sure that they're not stateful.) A few needed an additionalstringToWordSpansparameter. I also moved the call toskipMatchout ofgetMatchesandgetMatchesForLastSegmentOfPatternto avoid giving them an extra parameter.Sequel to #20143, #13548, #13534, #13476