Fix indexed access in conditional type#22707
Merged
ahejlsberg merged 7 commits intoMar 21, 2018
mastermicrosoft/TypeScript:masterfrom
fixIndexedAccessInConditionalTypemicrosoft/TypeScript:fixIndexedAccessInConditionalTypeCopy head branch name to clipboard
Merged
Fix indexed access in conditional type#22707ahejlsberg merged 7 commits intomastermicrosoft/TypeScript:masterfrom fixIndexedAccessInConditionalTypemicrosoft/TypeScript:fixIndexedAccessInConditionalTypeCopy head branch name to clipboard
ahejlsberg merged 7 commits into
mastermicrosoft/TypeScript:masterfrom
fixIndexedAccessInConditionalTypemicrosoft/TypeScript:fixIndexedAccessInConditionalTypeCopy head branch name to clipboard
Conversation
RyanCavanaugh
approved these changes
Mar 20, 2018
DanielRosenwasser
approved these changes
Mar 21, 2018
| } | ||
|
|
||
| function getImpliedConstraint(typeVariable: TypeVariable, checkNode: TypeNode, extendsNode: TypeNode): Type { | ||
| return isUnaryTupleTypeNode(checkNode) && isUnaryTupleTypeNode(extendsNode) ? getImpliedConstraint(typeVariable, (<TupleTypeNode>checkNode).elementTypes[0], (<TupleTypeNode>extendsNode).elementTypes[0]) : |
Member
There was a problem hiding this comment.
Nit: shorten this line
Member
There was a problem hiding this comment.
Also, if you made isUnaryTupleTypeNode a type predicate, you could potentially avoid the type assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, when the checked type in a conditional type is an indexed access type, we now add an implicit constraint to the type in the true branch.
Also, this PR fixes an issue where implicit constraints are not combined in nested conditional types.
Fixes #21729.