Filter symbol property names out of index signature assignability checks#22398
Merged
weswigham merged 1 commit intoMar 8, 2018
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:symbol-indexing-bugweswigham/TypeScript:symbol-indexing-bugCopy head branch name to clipboard
Merged
Filter symbol property names out of index signature assignability checks#22398weswigham merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:symbol-indexing-bugweswigham/TypeScript:symbol-indexing-bugCopy head branch name to clipboard
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:symbol-indexing-bugweswigham/TypeScript:symbol-indexing-bugCopy head branch name to clipboard
Conversation
mhegazy
approved these changes
Mar 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21962
The increased usage of
getLiteralTypeFromPropertyNamealso educated me that we do, actually, make symbols whose targets have different names than themselves - namely computed names that are dynamic. 😝