Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Mark SymbolTracker as deprecated publicly#22384

Merged
1 commit merged into
mastermicrosoft/TypeScript:masterfrom
symboltrackermicrosoft/TypeScript:symboltrackerCopy head branch name to clipboard
Mar 7, 2018
Merged

Mark SymbolTracker as deprecated publicly#22384
1 commit merged into
mastermicrosoft/TypeScript:masterfrom
symboltrackermicrosoft/TypeScript:symboltrackerCopy head branch name to clipboard

Conversation

@ghost

@ghost ghost commented Mar 7, 2018

Copy link
Copy Markdown

This type was publicly exposed, but was only used as a base type for SymbolWriter, which is deprecated.
(EmitTextWriter also extended from it, but it already gets that from extending SymbolWriter.) Also removed duplicate declarations on EmitTextWriter that it was already inheriting.

We could also fully make SymbolTracker internal and copy its methods to SymbolWriter.

@ghost ghost requested a review from weswigham March 7, 2018 18:41
@ghost ghost merged commit c0ac687 into master Mar 7, 2018
@ghost ghost deleted the symboltracker branch March 7, 2018 19:25
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.