Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Port generated lib files#22381

Merged
mhegazy merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
portGeneratedLibFiles3-7microsoft/TypeScript:portGeneratedLibFiles3-7Copy head branch name to clipboard
Mar 7, 2018
Merged

Port generated lib files#22381
mhegazy merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
portGeneratedLibFiles3-7microsoft/TypeScript:portGeneratedLibFiles3-7Copy head branch name to clipboard

Conversation

@mhegazy

@mhegazy mhegazy commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

@mhegazy mhegazy added the Breaking Change Would introduce errors in existing code label Mar 7, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Mar 7, 2018
@mhegazy mhegazy mentioned this pull request Mar 7, 2018
Closed
@mhegazy mhegazy mentioned this pull request Mar 7, 2018
Closed
@mhegazy mhegazy merged commit 963acb3 into master Mar 7, 2018
@mhegazy mhegazy deleted the portGeneratedLibFiles3-7 branch March 7, 2018 22:41
@mhegazy mhegazy mentioned this pull request Mar 9, 2018
Merged
@styfle

styfle commented Apr 1, 2018

Copy link
Copy Markdown
Contributor

@mhegazy This change broke my code because selectionStart: number is now selectionStart: number | null on interface HTMLInputElement. The same for selectionEnd.

However I don't believe this is correct because MDN doesn't mention that the property is nullable.

When would this return null?

@mhegazy

mhegazy commented Apr 2, 2018

Copy link
Copy Markdown
Contributor Author

Please file a new ticket and will get it fixed.

@styfle styfle mentioned this pull request Apr 2, 2018
Closed
@styfle

styfle commented Apr 2, 2018

Copy link
Copy Markdown
Contributor

@mhegazy Thanks, I created #23094

@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking Change Would introduce errors in existing code

Projects

None yet

Milestone

TypeScript 2.8

Development

Successfully merging this pull request may close these issues.

2 participants

@mhegazy @styfle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.