Use single replacer for string escaping#22335
Merged
weswigham merged 1 commit intoMar 8, 2018
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:robust-string-escapeweswigham/TypeScript:robust-string-escapeCopy head branch name to clipboard
Merged
Use single replacer for string escaping#22335weswigham merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:robust-string-escapeweswigham/TypeScript:robust-string-escapeCopy head branch name to clipboard
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:robust-string-escapeweswigham/TypeScript:robust-string-escapeCopy head branch name to clipboard
Conversation
| function getReplacement(c: string, offset: number, input: string) { | ||
| if (c.charCodeAt(0) === CharacterCodes.nullCharacter) { | ||
| const lookAhead = input.charCodeAt(offset + c.length); | ||
| if (lookAhead >= CharacterCodes._0 && lookAhead <= CharacterCodes._9) { |
Member
There was a problem hiding this comment.
This technically only needs to be 0 through 7 (isOctalDigit), but I'm fine with this.
DanielRosenwasser
approved these changes
Mar 6, 2018
Member
|
By the way, I wrote this code back when we couldn't use But that can be another PR. |
mhegazy
approved these changes
Mar 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-stage replacement was making non-null characters look like null chracters to the second replacer, which is no good. Now all the replacing is handled within one replacer, which also does the lookahead for potential octalyness conflicts.
Fixes #21828