Assert the result of getTokenValue is defined#21339
Closed
ghost wants to merge 1 commit into
mastermicrosoft/TypeScript:masterfrom
assertTokenValueDefinedmicrosoft/TypeScript:assertTokenValueDefinedCopy head branch name to clipboard
Closed
Assert the result of getTokenValue is defined#21339ghost wants to merge 1 commit intomastermicrosoft/TypeScript:masterfrom assertTokenValueDefinedmicrosoft/TypeScript:assertTokenValueDefinedCopy head branch name to clipboard
getTokenValue is defined#21339ghost wants to merge 1 commit into
mastermicrosoft/TypeScript:masterfrom
assertTokenValueDefinedmicrosoft/TypeScript:assertTokenValueDefinedCopy head branch name to clipboard
Conversation
6500760 to
79a0f37
Compare
mhegazy
suggested changes
Feb 2, 2018
Author
|
OK, better fix at #21581 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stab at #20792. In that issue an identifier has no
escapedTextset -- that eventually comes from here.