LanguageServiceShim.getCompletionEntryDetails: Support undefined options#20810
Merged
2 commits merged intoDec 20, 2017
Merged
LanguageServiceShim.getCompletionEntryDetails: Support undefined options#208102 commits merged into
2 commits merged into
Conversation
Member
|
Thanks! Yeah, I spotted the commit difference after I sent the email. Sorry about that. I tried this change on Dev14 and it looks good. Can you port to release-2.6 and merge there too. Thanks for the fast turnaround! |
billti
approved these changes
Dec 20, 2017
ghost
pushed a commit
that referenced
this pull request
Dec 20, 2017
…ons (#20810) * LanguageServiceShim.getCompletionEntryDetails: Support undefined options * Fix lint
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on an email from @billti
The commit that added the
JSON.parsecall was 2b566b9, not 0f32f55 which only changed type declarations.