Switch the pretty output to use colons to separate file:line:char so that lines are clickable in terminals#20736
Merged
mhegazy merged 1 commit intoJan 5, 2018
microsoft:mastermicrosoft/TypeScript:masterfrom
orta:use_colors_pretty_outputorta/TypeScript:use_colors_pretty_outputCopy head branch name to clipboard
Merged
Switch the pretty output to use colons to separate file:line:char so that lines are clickable in terminals#20736mhegazy merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom orta:use_colors_pretty_outputorta/TypeScript:use_colors_pretty_outputCopy head branch name to clipboard
mhegazy merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
orta:use_colors_pretty_outputorta/TypeScript:use_colors_pretty_outputCopy head branch name to clipboard
Conversation
|
Actually the current format is clickable inside VScode, but this way it works both in sublime and atom. Unfortunately I cannot verify if this works in VSCode tonight, maybe someone else can verify it? |
Contributor
Author
|
It does, yes:
|
|
Cool! Carry on then :) |
Member
Member
|
Sorry, the baselines are now out of date because I just merged in #20416. |
Contributor
|
@DanielRosenwasser The VS Code TS extension doesn't use |
17260b2 to
9c67064
Compare
Contributor
Author
|
Cool - that should be it updated & rebased 👍 |
Member
|
VS doesn't appear to use that option. |
…that lines are clickable in terminals
9c67064 to
2be5bae
Compare
DanielRosenwasser
approved these changes
Jan 5, 2018
Contributor
|
thanks @orta! and sorry for the delay. |
Contributor
Author
|
You're welcome, it was over the holidays, so low expectation 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
tsc, withprettyenabled, gives an error messages they look like this:You cannot directly click on
source/commands/init/state-setup.ts(21,40):to jump directly to the line of code, which is ideal. The format, by convention, for that syntax isfile:line:char- which this PR switches the message format to.For example, most testing libraries will output in this format (though I think this just comes from node's exception handling, but you get the point)
I couldn't find an issue for this, happy to write one up, but it seemed simple enough to just write a PR instead.