Use TypeFlags.UnionOrIntersection in isLiteralOfContextualType not TypeFlags.Union#20662
Merged
weswigham merged 1 commit intoDec 13, 2017
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-contextual-intersectionsweswigham/TypeScript:fix-contextual-intersectionsCopy head branch name to clipboard
Merged
Use TypeFlags.UnionOrIntersection in isLiteralOfContextualType not TypeFlags.Union#20662weswigham merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:fix-contextual-intersectionsweswigham/TypeScript:fix-contextual-intersectionsCopy head branch name to clipboard
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-contextual-intersectionsweswigham/TypeScript:fix-contextual-intersectionsCopy head branch name to clipboard
Conversation
sandersn
approved these changes
Dec 13, 2017
This was referenced Dec 13, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We mistakenly used
TypeFlags.Unionand notTypeFlags.UnionOrIntersectionfor checking if this function needed to iterate over a type, so no intersection type could ever contribute to the literalness of a position. This fixes that.Fixes #20653