Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Port generated lib files#20213

Merged
mhegazy merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
portGeneratedLibFiles1121microsoft/TypeScript:portGeneratedLibFiles1121Copy head branch name to clipboard
Nov 22, 2017
Merged

Port generated lib files#20213
mhegazy merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
portGeneratedLibFiles1121microsoft/TypeScript:portGeneratedLibFiles1121Copy head branch name to clipboard

Conversation

@mhegazy

@mhegazy mhegazy commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

Un-breaks DT tests after #20177

@weswigham

weswigham commented Nov 22, 2017

Copy link
Copy Markdown
Member

Maybe we should add a

/**
 * @deprecated Directly use HTMLElementTagNameMap or SVGElementTagNameMap as appropriate, instead
 */

just for documentation on the combined type if we think using it is probably a mistake?

@mhegazy

mhegazy commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

Will do

@mhegazy mhegazy merged commit d62a8be into master Nov 22, 2017
@mhegazy mhegazy deleted the portGeneratedLibFiles1121 branch November 22, 2017 23:42
@mhegazy

mhegazy commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

Deprecation notice added in microsoft/TypeScript-DOM-lib-generator#330

errendir added a commit to errendir/TypeScript that referenced this pull request Nov 27, 2017
* origin/master:
  LEGO: check in for master to temporary branch.
  Fix microsoft#19959 and microsoft#19958: Remove un-localizable messages (microsoft#20019)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Port generated lib files (microsoft#20213)
  Update test baseline
  Offer global completions in all blocks
  Accept new baselines
  Add regression test
  Make sure 'async' isn't treated as a parameter modifier
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.