Fix assertion -- an import may come from a require() call (#19667)#19810
Merged
1 commit merged intoNov 7, 2017
release-2.6microsoft/TypeScript:release-2.6from
release-2.6_completionsimport_requiremicrosoft/TypeScript:release-2.6_completionsimport_requireCopy head branch name to clipboard
Merged
Fix assertion -- an import may come from a require() call (#19667)#198101 commit merged intorelease-2.6microsoft/TypeScript:release-2.6from release-2.6_completionsimport_requiremicrosoft/TypeScript:release-2.6_completionsimport_requireCopy head branch name to clipboard
1 commit merged into
release-2.6microsoft/TypeScript:release-2.6from
release-2.6_completionsimport_requiremicrosoft/TypeScript:release-2.6_completionsimport_requireCopy head branch name to clipboard
Conversation
* Fix assertion -- an import may come from a require() call
* Add test for `import("./a")`
mhegazy
approved these changes
Nov 7, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #19667