Regression test for #19328#19599
Closed
weswigham wants to merge 2 commits into
mastermicrosoft/TypeScript:masterfrom
extract-function-with-captures-genericmicrosoft/TypeScript:extract-function-with-captures-genericCopy head branch name to clipboard
Closed
Regression test for #19328#19599weswigham wants to merge 2 commits intomastermicrosoft/TypeScript:masterfrom extract-function-with-captures-genericmicrosoft/TypeScript:extract-function-with-captures-genericCopy head branch name to clipboard
weswigham wants to merge 2 commits into
mastermicrosoft/TypeScript:masterfrom
extract-function-with-captures-genericmicrosoft/TypeScript:extract-function-with-captures-genericCopy head branch name to clipboard
Conversation
Member
Author
|
Correction: This is does not repro in the test harness but is still not fixed in a real editor! @amcasey any idea on how the extract function unit test environment differs from a real editing scenario for this usecase? |
Member
|
As I suggested offline, it would probably be easier to add a fourslash test than to revise all of the test infrastructure. |
Member
Author
Correction to the correction! The unit tests shows as fixed because it is fixed! I was loading the wrong LS when I tested in-editor. This was fixed by #19578 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it seems to already be fixed. As an added bonus, this allows the extract function/symbol tests to test multi-file programs.