Fix anonymous type instantiation#19091
Merged
ahejlsberg merged 6 commits intoOct 11, 2017
mastermicrosoft/TypeScript:masterfrom
fixAnonymousTypeInstantiationmicrosoft/TypeScript:fixAnonymousTypeInstantiationCopy head branch name to clipboard
Merged
Fix anonymous type instantiation#19091ahejlsberg merged 6 commits intomastermicrosoft/TypeScript:masterfrom fixAnonymousTypeInstantiationmicrosoft/TypeScript:fixAnonymousTypeInstantiationCopy head branch name to clipboard
ahejlsberg merged 6 commits into
mastermicrosoft/TypeScript:masterfrom
fixAnonymousTypeInstantiationmicrosoft/TypeScript:fixAnonymousTypeInstantiationCopy head branch name to clipboard
Conversation
Contributor
|
here is another example using declare function f<T>(a: T, b: { a: typeof a });
f(2, { a: 2 }); |
mhegazy
approved these changes
Oct 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #18231 we included an optimization to track which type parameters are referenced in anonymous types such that unnecessary instantiations can be avoided. This optimization did not properly account for locally declared types that might reference type parameters. With this PR we now optimize only when there are no intervening statement blocks between an anonymous type literal and a particular type parameter (and thus no opportunity to indirectly reference the type parameter), and no type queries (
typeofin a type position) within the anonymous type literal.Fixes #19043.