Make some new APIs internal and accept API baselines#18903
Merged
Make some new APIs internal and accept API baselines#18903
Conversation
weswigham
approved these changes
Oct 3, 2017
mihailik
reviewed
Oct 3, 2017
| fileNames: string[]; | ||
| wildcardDirectories: MapLike<WatchDirectoryFlags>; | ||
| spec: ConfigFileSpecs; | ||
| /* @internal */ spec: ConfigFileSpecs; |
Contributor
There was a problem hiding this comment.
Should this be optional? This member later feeds into an optional configFileSpec declared as optional/internal here above at line 3835.
Contributor
There was a problem hiding this comment.
In fact it looks like whole ExpandResult is never exposed anywhere through any API, except for the declaration of the interface itself.
So the /* @internal */ mark should go on whole ExpandResult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #