Fix forEachChild jsdoc @typedef tag#18333
Merged
sandersn merged 4 commits intoSep 8, 2017
mastermicrosoft/TypeScript:masterfrom
fix-forEachChild-JSDocTypedefTagmicrosoft/TypeScript:fix-forEachChild-JSDocTypedefTagCopy head branch name to clipboard
Merged
Fix forEachChild jsdoc @typedef tag#18333sandersn merged 4 commits intomastermicrosoft/TypeScript:masterfrom fix-forEachChild-JSDocTypedefTagmicrosoft/TypeScript:fix-forEachChild-JSDocTypedefTagCopy head branch name to clipboard
@typedef tag#18333sandersn merged 4 commits into
mastermicrosoft/TypeScript:masterfrom
fix-forEachChild-JSDocTypedefTagmicrosoft/TypeScript:fix-forEachChild-JSDocTypedefTagCopy head branch name to clipboard
Conversation
Also remove JSDocTypeLiteral.jsdocTypeTag, which made no sense since it was only useful when storing information for its parent `@typedef` tag.
ghost
approved these changes
Sep 8, 2017
| } | ||
| typedefTag.typeExpression = finishNode(jsdocTypeLiteral); | ||
| const useChildTypeTagAsType = childTypeTag && !isObjectOrObjectArrayTypeReference(childTypeTag.typeExpression.type); | ||
| typedefTag.typeExpression = useChildTypeTagAsType ? childTypeTag.typeExpression : finishNode(jsdocTypeLiteral); |
There was a problem hiding this comment.
Probably better to make these one expression so that if we have strictNullChecks TS can infer that we just checked for childTypeTag being defined.
This was referenced Sep 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@typedeftag.visitNodes.Fixes #18301