Don't try to extract import to a method#18025
Merged
1 commit merged intoAug 25, 2017
mastermicrosoft/TypeScript:masterfrom
extract-method-not-for-importmicrosoft/TypeScript:extract-method-not-for-importCopy head branch name to clipboard
Merged
Don't try to extract import to a method#180251 commit merged intomastermicrosoft/TypeScript:masterfrom extract-method-not-for-importmicrosoft/TypeScript:extract-method-not-for-importCopy head branch name to clipboard
import to a method#180251 commit merged into
mastermicrosoft/TypeScript:masterfrom
extract-method-not-for-importmicrosoft/TypeScript:extract-method-not-for-importCopy head branch name to clipboard
Conversation
RyanCavanaugh
approved these changes
Aug 25, 2017
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2017
This was referenced Aug 25, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17997
Replaced an invalid
as Expressioncast with a check forisExpression.I had to refactor
isExpressionto take aNodeand not aSyntaxKindbecause anImportKeywordis an expression only if its parent is aCallExpression. @rbuckton I hope that doesn't hurt performance?