Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Minor cleanups in builder#17208

Merged
2 commits merged into
mastermicrosoft/TypeScript:masterfrom
buildermicrosoft/TypeScript:builderCopy head branch name to clipboard
Jul 17, 2017
Merged

Minor cleanups in builder#17208
2 commits merged into
mastermicrosoft/TypeScript:masterfrom
buildermicrosoft/TypeScript:builderCopy head branch name to clipboard

Conversation

@ghost

@ghost ghost commented Jul 14, 2017

Copy link
Copy Markdown

Add insertSorted and removeSorted to server utilities.

@ghost ghost requested a review from sheetalkamat July 14, 2017 21:03
Comment thread src/server/builder.ts Outdated
// Equal. Go to next
oldIndex++;
newIndex++;
switch (compare) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given you have c;leaned this up, is it possible to use enumerate inserted and deleted from utilities instead

@ghost ghost force-pushed the builder branch from a9aea4b to 6e61c51 Compare July 17, 2017 16:39

@sheetalkamat sheetalkamat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@ghost ghost merged commit 555776e into master Jul 17, 2017
@ghost ghost deleted the builder branch July 17, 2017 19:24
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.