Inline getDestructuringParameterName#16973
Merged
2 commits merged intoJul 7, 2017
mastermicrosoft/TypeScript:masterfrom
getDestructuringParameterNamemicrosoft/TypeScript:getDestructuringParameterNameCopy head branch name to clipboard
Merged
Inline getDestructuringParameterName#169732 commits merged intomastermicrosoft/TypeScript:masterfrom getDestructuringParameterNamemicrosoft/TypeScript:getDestructuringParameterNameCopy head branch name to clipboard
getDestructuringParameterName#169732 commits merged into
mastermicrosoft/TypeScript:masterfrom
getDestructuringParameterNamemicrosoft/TypeScript:getDestructuringParameterNameCopy head branch name to clipboard
Conversation
weswigham
approved these changes
Jul 6, 2017
weswigham
left a comment
Member
There was a problem hiding this comment.
Seems like a good change, pending CI.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function contained a cast which was only valid due to
nodehaving a more specific type at its only use.It was simpler to remove the cast and inline it.
Also added a type definition to an object literal that was missing one.