Improve excess property check error span for spread property#16530
Merged
sandersn merged 4 commits intoJun 14, 2017
mastermicrosoft/TypeScript:masterfrom
excess-property-check-error-span-for-spread-propertymicrosoft/TypeScript:excess-property-check-error-span-for-spread-propertyCopy head branch name to clipboard
Merged
Improve excess property check error span for spread property#16530sandersn merged 4 commits intomastermicrosoft/TypeScript:masterfrom excess-property-check-error-span-for-spread-propertymicrosoft/TypeScript:excess-property-check-error-span-for-spread-propertyCopy head branch name to clipboard
sandersn merged 4 commits into
mastermicrosoft/TypeScript:masterfrom
excess-property-check-error-span-for-spread-propertymicrosoft/TypeScript:excess-property-check-error-span-for-spread-propertyCopy head branch name to clipboard
Conversation
Fall back to the assignment's declaration; don't use the property's valueDeclaration because that is not useful when the property comes from a spread. The fallback now happens when the property's valueDeclaration does not have the object literal's valueDeclaration as an ancestor.
valueDeclaration is frequently not set
Member
|
Seems pretty reasonable, but leave a comment in the code on what would happen if you weren't doing this check. 👍 |
mhegazy
approved these changes
Jun 14, 2017
Contributor
|
Please port to release-2.4 |
Member
Author
|
Ported to release-2.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to the assignment's declaration; don't use the property's valueDeclaration because that is not useful when the property comes from a spread. The fallback now happens when the property's valueDeclaration does not have the object literal's first declaration as an ancestor.
Fixes #16473