Weak type errors for primitives#16343
Merged
sandersn merged 4 commits intoJun 9, 2017
mastermicrosoft/TypeScript:masterfrom
weak-types-for-primitivesmicrosoft/TypeScript:weak-types-for-primitivesCopy head branch name to clipboard
Merged
Weak type errors for primitives#16343sandersn merged 4 commits intomastermicrosoft/TypeScript:masterfrom weak-types-for-primitivesmicrosoft/TypeScript:weak-types-for-primitivesCopy head branch name to clipboard
sandersn merged 4 commits into
mastermicrosoft/TypeScript:masterfrom
weak-types-for-primitivesmicrosoft/TypeScript:weak-types-for-primitivesCopy head branch name to clipboard
Conversation
It doesn't make sense to say that 'toString' is part of a weak type since having 'toString' would mean that the type isn't actually weak.
yuit
approved these changes
Jun 9, 2017
Merged
This was referenced Aug 17, 2017
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16333
Previously, weak type errors didn't occur with primitive sources because the apparent type of primitives all include
toString.isKnownPropertyreports thattoStringis known for all types because it falls back toglobalObjectTypewhen it can't find the property on the given type.