discoverTypings should look at typingSafelist.json values#16277
Merged
minestarks merged 2 commits intoJun 6, 2017
microsoft:mastermicrosoft/TypeScript:masterfrom
minestarks:safelistpackagenamesminestarks/TypeScript:safelistpackagenamesCopy head branch name to clipboard
Merged
discoverTypings should look at typingSafelist.json values#16277minestarks merged 2 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom minestarks:safelistpackagenamesminestarks/TypeScript:safelistpackagenamesCopy head branch name to clipboard
minestarks merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
minestarks:safelistpackagenamesminestarks/TypeScript:safelistpackagenamesCopy head branch name to clipboard
Conversation
mhegazy
approved these changes
Jun 5, 2017
mhegazy
left a comment
Contributor
There was a problem hiding this comment.
Can you add a unit test to harness\unittests\typingsInstaller.ts
ghost
reviewed
Jun 6, 2017
|
|
||
| if (safeList !== EmptySafeList) { | ||
| mergeTypings(filter(cleanedTypingNames, f => safeList.has(f))); | ||
| mergeTypings(map(filter(cleanedTypingNames, f => safeList.has(f)), (f => safeList.get(f)))); |
There was a problem hiding this comment.
This looks like a good candidate to use ts.mapDefined(cleanedTypingNames, f => safeList.get(f)).
ghost
approved these changes
Jun 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm package names in typingSafeList.json were getting ignored, breaking type acquisition for packages where file name != package name