Fix reexported missing alias#16194
Merged
sandersn merged 2 commits intoJun 5, 2017
mastermicrosoft/TypeScript:masterfrom
fix-reexported-missing-aliasmicrosoft/TypeScript:fix-reexported-missing-aliasCopy head branch name to clipboard
Merged
Fix reexported missing alias#16194sandersn merged 2 commits intomastermicrosoft/TypeScript:masterfrom fix-reexported-missing-aliasmicrosoft/TypeScript:fix-reexported-missing-aliasCopy head branch name to clipboard
sandersn merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
fix-reexported-missing-aliasmicrosoft/TypeScript:fix-reexported-missing-aliasCopy head branch name to clipboard
Conversation
Previously, when getExternalModuleMember tried to combine unknownSymbol from a type and unknownSymbol from a value, it combineValueAndTypeSymbol would create a new franken-symbol that was no longer equal to unknownSymbol.
mhegazy
approved these changes
Jun 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when getExternalModuleMember tried to combine unknownSymbol from a type and unknownSymbol from a value, combineValueAndTypeSymbol would create a new franken-symbol that was no longer equal to unknownSymbol. Now combineValueAndTypeSymbol just returns unknownSymbol.
Fixes #15094