Check applicable signature fix#16104
Closed
gcnew wants to merge 10 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
gcnew:checkApplicableSignatureFixgcnew/TypeScript:checkApplicableSignatureFixCopy head branch name to clipboard
Closed
Check applicable signature fix#16104gcnew wants to merge 10 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom gcnew:checkApplicableSignatureFixgcnew/TypeScript:checkApplicableSignatureFixCopy head branch name to clipboard
gcnew wants to merge 10 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
gcnew:checkApplicableSignatureFixgcnew/TypeScript:checkApplicableSignatureFixCopy head branch name to clipboard
Conversation
93e0e7d to
69b2e7c
Compare
ee05467 to
144a018
Compare
Member
|
I think the issues fixed by this PR are now covered in a more general way by #16368. |
Contributor
Author
|
Yes, indeed. #16368 fixes the instantiation/type constraints issues in a more general way. |
Contributor
Author
|
Closing this on in favour of #16368. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use parameter inference when checking whether the provided arguments are applicable on the (inferred) signature.
Fixes #3410, #14766, #16107