cache semantic and declaration diagnostics in program#14516
Merged
vladima merged 2 commits intoMar 7, 2017
mastermicrosoft/TypeScript:masterfrom
vladima/cache-diagnosticsmicrosoft/TypeScript:vladima/cache-diagnosticsCopy head branch name to clipboard
Merged
cache semantic and declaration diagnostics in program#14516vladima merged 2 commits intomastermicrosoft/TypeScript:masterfrom vladima/cache-diagnosticsmicrosoft/TypeScript:vladima/cache-diagnosticsCopy head branch name to clipboard
vladima merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
vladima/cache-diagnosticsmicrosoft/TypeScript:vladima/cache-diagnosticsCopy head branch name to clipboard
Conversation
mhegazy
approved these changes
Mar 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semantic\declaration diagnostics are quite expensive to compute and the cost is not reflected in API. This makes it very easy to incur significant perf issues if consumer of the API repeatedly calls i.e.
getDeclarationDiagnosticson the program.