Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Allow the right-hand side of an 'in' expression to be of non-primitive object type#14467

Merged
DanielRosenwasser merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
kpreisser:fix14269kpreisser/TypeScript:fix14269Copy head branch name to clipboard
Mar 31, 2017
Merged

Allow the right-hand side of an 'in' expression to be of non-primitive object type#14467
DanielRosenwasser merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
kpreisser:fix14269kpreisser/TypeScript:fix14269Copy head branch name to clipboard

Conversation

@kpreisser

@kpreisser kpreisser commented Mar 5, 2017

Copy link
Copy Markdown
Contributor

Fixes #14269

(The issue does not yet have a 'bug' label but I think it can be fixed in the same way as PR #14195)

Thanks!

@msftclas

msftclas commented Mar 5, 2017

Copy link
Copy Markdown

@kpreisser,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

msftclas commented Mar 5, 2017

Copy link
Copy Markdown

@kpreisser, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@RyanCavanaugh

Copy link
Copy Markdown
Member

LGTM. Anyone else want to check it?

@DanielRosenwasser DanielRosenwasser merged commit 0459987 into microsoft:master Mar 31, 2017
@DanielRosenwasser

Copy link
Copy Markdown
Member

Thanks @kpreisser!

@kpreisser kpreisser deleted the fix14269 branch March 31, 2017 06:39
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

object type does not work with in operator

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.