String literal completions: Use call signature only if we are *immediately* in a call expression#13364
Merged
1 commit merged intoJan 9, 2017
mastermicrosoft/TypeScript:masterfrom
string_literal_completions_fixmicrosoft/TypeScript:string_literal_completions_fixCopy head branch name to clipboard
Merged
String literal completions: Use call signature only if we are *immediately* in a call expression#133641 commit merged intomastermicrosoft/TypeScript:masterfrom string_literal_completions_fixmicrosoft/TypeScript:string_literal_completions_fixCopy head branch name to clipboard
1 commit merged into
mastermicrosoft/TypeScript:masterfrom
string_literal_completions_fixmicrosoft/TypeScript:string_literal_completions_fixCopy head branch name to clipboard
Conversation
…ately* in a call expression
mhegazy
approved these changes
Jan 9, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12224
The problem was that in a call
foo({ x: "/**/" })we were trying to get string literal completions for the first argument, which is obviously not being filled in as a string literal. We should only do signature completions in the case offoo("/**/"), where we are immediately the argument tofoo.