Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Format JSX expression and closing token#13092

Merged
mhegazy merged 4 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
saschanaz:jsxdanglingsaschanaz/TypeScript:jsxdanglingCopy head branch name to clipboard
Dec 22, 2016
Merged

Format JSX expression and closing token#13092
mhegazy merged 4 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
saschanaz:jsxdanglingsaschanaz/TypeScript:jsxdanglingCopy head branch name to clipboard

Conversation

@saschanaz

@saschanaz saschanaz commented Dec 21, 2016 •
edited by DanielRosenwasser
Loading

Copy link
Copy Markdown
Contributor

Fixes #8663, fixes #12238.

Input+Fixed:

<div name="test"
     data="test"
     onClick={() => { }}
>
  <div>test</div>
</div>

(function () {}())

Current:

<div name="test"
    onClick={() => { } }
    data="test"
    >
    <div>test</div>
</div>

(function () {} ())

@saschanaz saschanaz changed the title Format JSX expression and cloning token Format JSX expression and closing token Dec 21, 2016
@saschanaz saschanaz mentioned this pull request Dec 21, 2016
Closed
@mhegazy

mhegazy commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

@saschanaz, can you rebase?

@saschanaz

saschanaz commented Dec 22, 2016

Copy link
Copy Markdown
Contributor Author

Done!

@mhegazy mhegazy merged commit c563e83 into microsoft:master Dec 22, 2016
@saschanaz saschanaz deleted the jsxdangling branch December 22, 2016 01:09
@mhegazy mhegazy mentioned this pull request Dec 22, 2016
Merged
This was referenced Dec 23, 2016
Closed
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Format Code: func-call-spacing error? JSX formatting

3 participants

@saschanaz @mhegazy @msftclas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.