Skip files from package.json "main" or "types" if they have an unsupported extension.#13024
Merged
mhegazy merged 2 commits intoDec 20, 2016
mastermicrosoft/TypeScript:masterfrom
package_json_unsupported_extensionmicrosoft/TypeScript:package_json_unsupported_extensionCopy head branch name to clipboard
Merged
Skip files from package.json "main" or "types" if they have an unsupported extension.#13024mhegazy merged 2 commits intomastermicrosoft/TypeScript:masterfrom package_json_unsupported_extensionmicrosoft/TypeScript:package_json_unsupported_extensionCopy head branch name to clipboard
mhegazy merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
package_json_unsupported_extensionmicrosoft/TypeScript:package_json_unsupported_extensionCopy head branch name to clipboard
Conversation
Author
|
Will need to rebase onto #13025 (when it's merged) to fix tests. |
vladima
reviewed
Dec 20, 2016
| return resolvedFromAnyFile(fromFile); | ||
| const fromExactFile = tryFile(mainOrTypesFile, failedLookupLocations, onlyRecordFailures, state); | ||
| if (fromExactFile) { | ||
| const resolved = fromExactFile && resolvedFromSuspiciousFile(extensions, fromExactFile); |
Contributor
There was a problem hiding this comment.
nit: I'd name it resolveIfExtensionMatches
vladima
approved these changes
Dec 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13004
The problem there is that the
normalize.cssmodule lists a file "normalize.css" as its "main" entry point.