Self-referencing spread recursive loop#12808
Merged
sandersn merged 2 commits intoDec 12, 2016
mastermicrosoft/TypeScript:masterfrom
self-referencing-spread-recursive-loopmicrosoft/TypeScript:self-referencing-spread-recursive-loopCopy head branch name to clipboard
Merged
Self-referencing spread recursive loop#12808sandersn merged 2 commits intomastermicrosoft/TypeScript:masterfrom self-referencing-spread-recursive-loopmicrosoft/TypeScript:self-referencing-spread-recursive-loopCopy head branch name to clipboard
sandersn merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
self-referencing-spread-recursive-loopmicrosoft/TypeScript:self-referencing-spread-recursive-loopCopy head branch name to clipboard
Conversation
Not checkExpressionCached. checkExpressionCached ignores ongoing control
flow analysis, which causes the following loop to make the compiler
recur infinitely:
```ts
let a = []
for (const x of []) {
a = [...a]
}
```
Member
|
Does |
Member
Author
|
|
Member
Author
|
Oops, this fixes #12735. I got the bug number wrong initially. |
mhegazy
approved these changes
Dec 12, 2016
Contributor
|
@sandersn please port this change to release-2.1 as well. |
Merged
Member
Author
|
Ok, I ported it. |
Contributor
|
never mind. i have a port already up: #12864 |
Member
Author
|
Sorry, I didn't see it until after I pushed . I wondered why I did t have merge conflicts with the new commits... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12735
Use
checkExpressionincheckSpreadExpression, notcheckExpressionCached.checkExpressionCachedignores ongoing control flow analysis, which causes the following loop to make the compiler recur infinitely:An alternate fix would make
checkExpressionCachednot ignore control flow analysis in some situations, but that's a much more complicated fix, I think. @ahejlsberg, do you have an opinion on whether that or some other fix is feasible?