Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix decorator emit for accessors#12740

Merged
mhegazy merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
fix12727microsoft/TypeScript:fix12727Copy head branch name to clipboard
Dec 8, 2016
Merged

Fix decorator emit for accessors#12740
mhegazy merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
fix12727microsoft/TypeScript:fix12727Copy head branch name to clipboard

Conversation

@rbuckton

@rbuckton rbuckton commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

This fixes an issue where the new emitter was not emitting decorators for accessor pairs where only the second accessor was decorated:

declare var dec: any;
class A {
    @dec() set value(value: string) { } // emits fine
    get value() { return ""; }
}
class B {
    set value(value: string) { }
    @dec() get value() { return ""; } // not emitted
}

Fixes #12727

//cc: @mhegazy

@mhegazy mhegazy merged commit da4d41f into master Dec 8, 2016
@mhegazy mhegazy deleted the fix12727 branch December 8, 2016 01:19
This was referenced Dec 9, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking changes in 2.1.4 with NG2.1

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.