remove projects that were no present in the input list in openExternalProjects#12699
Merged
vladima merged 2 commits intoDec 7, 2016
mastermicrosoft/TypeScript:masterfrom
vladima/remove-missing-projectsmicrosoft/TypeScript:vladima/remove-missing-projectsCopy head branch name to clipboard
Merged
remove projects that were no present in the input list in openExternalProjects#12699vladima merged 2 commits intomastermicrosoft/TypeScript:masterfrom vladima/remove-missing-projectsmicrosoft/TypeScript:vladima/remove-missing-projectsCopy head branch name to clipboard
vladima merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
vladima/remove-missing-projectsmicrosoft/TypeScript:vladima/remove-missing-projectsCopy head branch name to clipboard
Conversation
jramsay
reviewed
Dec 7, 2016
| openExternalProject(proj: protocol.ExternalProject): void { | ||
| openExternalProjects(projects: protocol.ExternalProject[]): void { | ||
| // record project list before the update | ||
| const projectsToClose = arrayToMap(this.externalProjects, p => p.getProjectName(), _ => true); |
Member
There was a problem hiding this comment.
nit: remove extra space between = and arrayToMap
jramsay
approved these changes
Dec 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// cc @jramsay, @mhegazy