Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add node6 to ci#12591

Merged
mhegazy merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
chicoxyzzy:add_node6_to_cichicoxyzzy/TypeScript:add_node6_to_ciCopy head branch name to clipboard
Dec 12, 2016
Merged

Add node6 to ci#12591
mhegazy merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
chicoxyzzy:add_node6_to_cichicoxyzzy/TypeScript:add_node6_to_ciCopy head branch name to clipboard

Conversation

@chicoxyzzy

Copy link
Copy Markdown
Contributor
  • Add Node.js 6 LTS to CI
  • Drop unmaintained versions of Node.js from package.json

@msftclas

Copy link
Copy Markdown

Hi @chicoxyzzy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@RyanCavanaugh

Copy link
Copy Markdown
Member

@dotnet-bot test ci please

@chicoxyzzy

chicoxyzzy commented Nov 30, 2016

Copy link
Copy Markdown
Contributor Author

Is it ok that there are no running tests for Node 6 on .NET CI?

@RyanCavanaugh

Copy link
Copy Markdown
Member

@dotnet-bot test this please

@RyanCavanaugh

Copy link
Copy Markdown
Member

The jobs have to be manually enabled after they're created - figuring out how to get that rolling here. Is there an issue tracking this PR?

@chicoxyzzy

Copy link
Copy Markdown
Contributor Author

I didn't find any.

Also I've singed CLA. Should I call some bot to check it?

@msftgits

msftgits commented Dec 2, 2016

Copy link
Copy Markdown

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Dec 2, 2016
@msftgits msftgits reopened this Dec 2, 2016
@msftclas

msftclas commented Dec 2, 2016

Copy link
Copy Markdown

Hi @chicoxyzzy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mhegazy mhegazy merged commit 23ec976 into microsoft:master Dec 12, 2016
@mhegazy mhegazy mentioned this pull request Dec 12, 2016
@chicoxyzzy chicoxyzzy deleted the add_node6_to_ci branch December 13, 2016 19:15
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.