Reset the noEmitForJsFiles option when updating compiler options#12570
Merged
zhengbli merged 4 commits intoNov 30, 2016
microsoft:release-2.1microsoft/TypeScript:release-2.1from
zhengbli:resetNoEmitForJsFileszhengbli/TypeScript:resetNoEmitForJsFilesCopy head branch name to clipboard
Merged
Reset the noEmitForJsFiles option when updating compiler options#12570zhengbli merged 4 commits intomicrosoft:release-2.1microsoft/TypeScript:release-2.1from zhengbli:resetNoEmitForJsFileszhengbli/TypeScript:resetNoEmitForJsFilesCopy head branch name to clipboard
zhengbli merged 4 commits into
microsoft:release-2.1microsoft/TypeScript:release-2.1from
zhengbli:resetNoEmitForJsFileszhengbli/TypeScript:resetNoEmitForJsFilesCopy head branch name to clipboard
Conversation
vladima
reviewed
Nov 30, 2016
| this.cachedUnresolvedImportsPerFile.clear(); | ||
| this.lastCachedUnresolvedImportsList = undefined; | ||
| } | ||
| if (this.projectKind === ProjectKind.Inferred || this.projectKind === ProjectKind.Configured) { |
Contributor
There was a problem hiding this comment.
This piece of code is similar to one in constructor - can you share it?
Contributor
|
Can you add tests? |
6af0600 to
b0c8a19
Compare
billti
reviewed
Nov 30, 2016
| const diagsAfterUpdate = session.executeCommand(<server.protocol.CompilerOptionsDiagnosticsRequest>{ | ||
| type: "request", | ||
| command: server.CommandNames.CompilerOptionsDiagnosticsFull, | ||
| seq: 3, |
Member
There was a problem hiding this comment.
I assume the "seq" number should increment with each request. You repeat "3" here (and also in the test below).
vladima
approved these changes
Nov 30, 2016
| this.markAsDirty(); | ||
| } | ||
|
|
||
| setInternalCompilerOptionsForEmittingJsFiles() { |
Member
Author
|
Sure, working on it. Edit: one minute, let me do a final round of local testing to be sure no surprise again. |
Author
|
@billti I created https://github.com/Microsoft/TypeScript/tree/vs/release-2.1 that has the changes in this PR. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.